build common as a library

common/Makefile.am

@@ -1,11 +1,7 @@
+lib_LTLIBRARIES = \
+  libxrdp-common.la
 
-INCLUDES = \
+libxrdp_common_la_SOURCES = \
-  -fPIC
-
-noinst_LIBRARIES = \
-  libxrdp-common.a
-
-libxrdp_common_a_SOURCES = \
   d3des.c \
   file.c \
   list.c \
@@ -13,3 +9,10 @@ libxrdp_common_a_SOURCES = \
   os_calls.c \
   ssl_calls.c \
   thread_calls.c
+
+libxrdp_common_la_LIBADD = \
+  -lcrypto \
+  -lpthread
+
+libxrdp_common_la_LDFLAGS = \
+  -version-info 5:0:5

libxrdp/Makefile.am

@@ -18,7 +18,7 @@ libxrdp_la_SOURCES = \
   xrdp_bitmap_compress.c
 
 libxrdp_la_LIBADD = \
-  $(top_srcdir)/common/libxrdp-common.a
+  $(top_srcdir)/common/libxrdp-common.la
 
 libxrdp_la_LDFLAGS = \
   -version-info 5:0:5

mc/Makefile.am

@@ -7,7 +7,7 @@ lib_LTLIBRARIES = \
 libmc_la_SOURCES = mc.c
 
 libmc_la_LIBADD = \
-  $(top_srcdir)/common/libxrdp-common.a
+  $(top_srcdir)/common/libxrdp-common.la
 
 libmc_la_LDFLAGS = \
   -version-info 5:0:5

rdp/Makefile.am

@@ -16,7 +16,7 @@ librdp_la_SOURCES = \
   rdp_tcp.c
 
 librdp_la_LIBADD = \
-  $(top_srcdir)/common/libxrdp-common.a
+  $(top_srcdir)/common/libxrdp-common.la
 
 librdp_la_LDFLAGS = \
   -version-info 5:0:5

sesman/Makefile.am

@@ -24,14 +24,11 @@ xrdp_sessvc_SOURCES = \
   sessvc.c
 
 xrdp_sesman_LDADD = \
-  $(top_srcdir)/common/libxrdp-common.a \
+  $(top_srcdir)/common/libxrdp-common.la \
   $(top_srcdir)/sesman/libscp/libscp.la \
-  -ldl \
-  -lpthread \
   -lpam
 
 xrdp_sessvc_LDADD = \
-  $(top_srcdir)/common/libxrdp-common.a \
+  $(top_srcdir)/common/libxrdp-common.la
-  -ldl
 
 SUBDIRS = libscp

sesman/libscp/Makefile.am

@@ -15,5 +15,8 @@ libscp_la_SOURCES = \
   libscp_v1s.c \
   libscp_vX.c
 
+libscp_la_LIBADD = \
+  $(top_srcdir)/common/libxrdp-common.la
+
 libscp_la_LDFLAGS = \
   -version-info 5:0:5

vnc/Makefile.am

@@ -7,7 +7,7 @@ lib_LTLIBRARIES = \
 libvnc_la_SOURCES = vnc.c
 
 libvnc_la_LIBADD = \
-  $(top_srcdir)/common/libxrdp-common.a
+  $(top_srcdir)/common/libxrdp-common.la
 
 libvnc_la_LDFLAGS = \
   -version-info 5:0:5

xup/Makefile.am

@@ -7,7 +7,7 @@ lib_LTLIBRARIES = \
 libxup_la_SOURCES = xup.c
 
 libxup_la_LIBADD = \
-  $(top_srcdir)/common/libxrdp-common.a
+  $(top_srcdir)/common/libxrdp-common.la
 
 libxup_la_LDFLAGS = \
   -version-info 5:0:5