Properly acquire a 32-bit ARGB visual when GL screen saver is requested

kdesktop/lock/lockprocess.cc

@@ -820,6 +820,7 @@ void LockProcess::createSaverWindow()
 {
     Visual* visual = CopyFromParent;
     XSetWindowAttributes attrs;
+    XVisualInfo* info = NULL;
     int flags = trinity_desktop_lock_use_system_modal_dialogs?0:CWOverrideRedirect;
 #ifdef HAVE_GLXCHOOSEVISUAL
     if( mOpenGLVisual )
@@ -845,23 +846,41 @@ void LockProcess::createSaverWindow()
         #undef G
         #undef B
         };
-        for( unsigned int i = 0;
+        for( unsigned int i = 0; i < sizeof( attribs ) / sizeof( attribs[ 0 ] ); ++i ) {
-             i < sizeof( attribs ) / sizeof( attribs[ 0 ] );
+            int n_glxfb_configs;
-             ++i )
+            GLXFBConfig *fbc = glXChooseFBConfig( x11Display(), x11Screen(), attribs[ i ], &n_glxfb_configs);
-        {
+            if (!fbc) {
-            if( XVisualInfo* info = glXChooseVisual( x11Display(), x11Screen(), attribs[ i ] ))
+                n_glxfb_configs = 0;
-            {
+            }
-                visual = info->visual;
+            for( int j = 0; j < n_glxfb_configs; j++ ) {
-                static Colormap colormap = 0;
+                info = glXGetVisualFromFBConfig(x11Display(), fbc[j]);
-                if( colormap != 0 )
+                if( info ) {
-                    XFreeColormap( x11Display(), colormap );
+                    if (argb_visual) {
-                colormap = XCreateColormap( x11Display(), RootWindow( x11Display(), x11Screen()), visual, AllocNone );
+                        if (info->depth < 32) {
-                attrs.colormap = colormap;
+                            XFree( info );
-                flags |= CWColormap;
+                            info = NULL;
-                XFree( info );
+                            continue;
+                        }
+                    }
+                    visual = info->visual;
+                    static Colormap colormap = 0;
+                    if( colormap != 0 ) {
+                        XFreeColormap( x11Display(), colormap );
+                    }
+                    colormap = XCreateColormap( x11Display(), RootWindow( x11Display(), x11Screen()), visual, AllocNone );
+                    attrs.colormap = colormap;
+                    flags |= CWColormap;
+                    break;
+                }
+            }
+            if (flags & CWColormap) {
                 break;
             }
         }
+        if ( !info )
+        {
+            printf("[WARNING] Unable to locate matching X11 GLX Visual; this OpenGL application may not function correctly!\n");
+        }
     }
 #endif
 
@@ -869,22 +888,38 @@ void LockProcess::createSaverWindow()
     hide();
 
     if (argb_visual) {
+        // The GL visual selection can return a visual with invalid depth
+        // Check for this and use a fallback visual if needed
+        if (info && (info->depth < 32)) {
+            printf("[WARNING] Unable to locate matching X11 GLX Visual; this OpenGL application may not function correctly!\n");
+            XFree( info );
+            info = NULL;
+            flags &= ~CWColormap;
+        }
+
         attrs.background_pixel = 0;
         attrs.border_pixel = 0;
         flags |= CWBackPixel;
         flags |= CWBorderPixel;
         if (!(flags & CWColormap)) {
-            XVisualInfo vinfo;
+            if (!info) {
-            if (!XMatchVisualInfo( x11Display(), x11Screen(), 32, TrueColor, &vinfo )) {
+                info = new XVisualInfo;
-                printf("[ERROR] Unable to locate matching X11 Visual; this application will not function correctly!\n");
+                if (!XMatchVisualInfo( x11Display(), x11Screen(), 32, TrueColor, info )) {
+                    printf("[ERROR] Unable to locate matching X11 Visual; this application will not function correctly!\n");
+                    free(info);
+                    info = NULL;
+                }
             }
-            else {
+            if (info) {
-                visual = vinfo.visual;
+                visual = info->visual;
                 attrs.colormap = XCreateColormap( x11Display(), RootWindow( x11Display(), x11Screen()), visual, AllocNone );
                 flags |= CWColormap;
             }
         }
     }
+    if (info) {
+        XFree( info );
+    }
 
     Window w = XCreateWindow( x11Display(), RootWindow( x11Display(), x11Screen()), x(), y(), width(), height(), 0, x11Depth(), InputOutput, visual, flags, &attrs );
     create( w );