Merge pull request #111 from zbierak/master

Fix buffer overflow when applying client encodings
9 years ago · 96a5111cba
parent 5ceccb0dfa 9b82dee3a4
commit 96a5111cba
1 changed files with 2 additions and 1 deletions
--- a/libvncclient/rfbproto.c
+++ b/libvncclient/rfbproto.c
@ -1492,7 +1492,8 @@ SetFormatAndEncodings(rfbClient* client)
    if(e->encodings) {
      int* enc;
      for(enc = e->encodings; *enc; enc++)
-	encs[se->nEncodings++] = rfbClientSwap32IfLE(*enc);
+        if(se->nEncodings < MAX_ENCODINGS)
+          encs[se->nEncodings++] = rfbClientSwap32IfLE(*enc);
    }

  len = sz_rfbSetEncodingsMsg + se->nEncodings * 4;