From 780ba744f6fd46dbfe01aec3f096f14f7346d609 Mon Sep 17 00:00:00 2001 From: Koichiro IWAO Date: Thu, 22 Mar 2018 12:37:42 +0900 Subject: [PATCH] Revert "devredir: fix xinode leak" This reverts commit 5daa09171e1e6e65a1a3ab969775fdf8affffc37. Causes "double free". Fix #990 was not correct. ``` [1271363627]: DEV_REDIR dev_redir_proc_device_iocompletion: 738 : entered: IoStatus=0x0 CompletionId=1 [1271363627]: DEV_REDIR dev_redir_proc_device_iocompletion: 839 : got CID_DIRECTORY_CONTROL [1271363627]: DEV_REDIR dev_redir_proc_query_dir_response: 933 : processing FILE_DIRECTORY_INFORMATION structs [1271363627]: DEV_REDIR dev_redir_proc_query_dir_response: 968 : FileName: . [1271363627]: DEV_REDIR devredir_fuse_data_peek: 1335 : returning 0x7f2a9c013410 *** Error in `/usr/sbin/xrdp-chansrv': double free or corruption (out): 0x00007f2a9c13a330 *** ``` Closes: #1025 --- sesman/chansrv/devredir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sesman/chansrv/devredir.c b/sesman/chansrv/devredir.c index 4c6f67e3..629b3cc9 100644 --- a/sesman/chansrv/devredir.c +++ b/sesman/chansrv/devredir.c @@ -986,8 +986,6 @@ dev_redir_proc_query_dir_response(IRP *irp, /* add this entry to xrdp file system */ fuse_data = devredir_fuse_data_peek(irp); xfuse_devredir_cb_enum_dir(fuse_data->data_ptr, xinode); - - g_free(xinode); } dev_redir_send_drive_dir_request(irp, DeviceId, 0, NULL);