From 73578bc612b63e451a9203f7187f77152d069350 Mon Sep 17 00:00:00 2001 From: Laxmikant Rashinkar Date: Sat, 19 Jul 2014 13:06:25 -0700 Subject: [PATCH] coverity: fixed unchecked return value --- rdp/rdp_mcs.c | 4 +++- sesman/chansrv/chansrv.c | 3 ++- sesman/chansrv/sound.c | 3 ++- sesman/sesman.c | 6 +++++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/rdp/rdp_mcs.c b/rdp/rdp_mcs.c index 55067b1f..18c33ac4 100644 --- a/rdp/rdp_mcs.c +++ b/rdp/rdp_mcs.c @@ -19,6 +19,7 @@ */ #include "rdp.h" +#include "common/log.h" /*****************************************************************************/ struct rdp_mcs *APP_CC @@ -598,7 +599,8 @@ failed")); int APP_CC rdp_mcs_init(struct rdp_mcs *self, struct stream *s) { - rdp_iso_init(self->iso_layer, s); + if (rdp_iso_init(self->iso_layer, s)) + log_message(LOG_LEVEL_ERROR, "rdp_mcs.c: rdp_iso_init() failed"); s_push_layer(s, mcs_hdr, 8); return 0; } diff --git a/sesman/chansrv/chansrv.c b/sesman/chansrv/chansrv.c index a89957ba..6aa5c8e8 100644 --- a/sesman/chansrv/chansrv.c +++ b/sesman/chansrv/chansrv.c @@ -812,7 +812,8 @@ my_api_trans_data_in(struct trans *trans) in_uint8s(s, 12); in_uint32_le(s, bytes_read); init_stream(s, bytes_read); - trans_force_read(trans, bytes_read); + if (trans_force_read(trans, bytes_read)) + log_message(LOG_LEVEL_ERROR, "chansrv.c: error reading from transport"); } else if (g_tcp_select(trans->sck, 0) & 1) { diff --git a/sesman/chansrv/sound.c b/sesman/chansrv/sound.c index a90bf905..c699ffde 100644 --- a/sesman/chansrv/sound.c +++ b/sesman/chansrv/sound.c @@ -1132,7 +1132,8 @@ sound_sndsrvr_source_data_in(struct trans *trans) return 1; ts = trans_get_in_s(trans); - trans_force_read(trans, 3); + if (trans_force_read(trans, 3)) + log_message(LOG_LEVEL_ERROR, "sound.c: error reading from transport"); ts->p = ts->data + 8; in_uint8(ts, cmd); diff --git a/sesman/sesman.c b/sesman/sesman.c index 83db5961..db755a65 100644 --- a/sesman/sesman.c +++ b/sesman/sesman.c @@ -361,7 +361,11 @@ main(int argc, char **argv) /* make sure the /tmp/.X11-unix directory exist */ if (!g_directory_exist("/tmp/.X11-unix")) { - g_create_dir("/tmp/.X11-unix"); + if (!g_create_dir("/tmp/.X11-unix")) + { + log_message(LOG_LEVEL_ERROR, + "sesman.c: error creating dir /tmp/.X11-unix"); + } g_chmod_hex("/tmp/.X11-unix", 0x1777); }