From a9d178f1000475ba1727ffe123a2c54585488c01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sl=C3=A1vek=20Banko?= Date: Tue, 26 Dec 2023 03:29:40 +0100 Subject: [PATCH] Fix potential buffer overflow in debug functions. This resolves issue #70. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Slávek Banko --- src/tools/qglobal.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tools/qglobal.cpp b/src/tools/qglobal.cpp index 8c8c82ac..3a331791 100644 --- a/src/tools/qglobal.cpp +++ b/src/tools/qglobal.cpp @@ -520,7 +520,7 @@ void tqDebug( const char *msg, ... ) va_list ap; va_start( ap, msg ); // use variable arg list #if defined(QT_VSNPRINTF) - QT_VSNPRINTF( &buf[len], QT_BUFFER_LENGTH, msg, ap ); + QT_VSNPRINTF( &buf[len], QT_BUFFER_LENGTH-len, msg, ap ); #else vsprintf( &buf[len], msg, ap ); #endif @@ -555,7 +555,7 @@ void tqWarning( const char *msg, ... ) va_list ap; va_start( ap, msg ); // use variable arg list #if defined(QT_VSNPRINTF) - QT_VSNPRINTF( &buf[len], QT_BUFFER_LENGTH, msg, ap ); + QT_VSNPRINTF( &buf[len], QT_BUFFER_LENGTH-len, msg, ap ); #else vsprintf( &buf[len], msg, ap ); #endif @@ -590,7 +590,7 @@ void tqFatal( const char *msg, ... ) va_list ap; va_start( ap, msg ); // use variable arg list #if defined(QT_VSNPRINTF) - QT_VSNPRINTF( &buf[len], QT_BUFFER_LENGTH, msg, ap ); + QT_VSNPRINTF( &buf[len], QT_BUFFER_LENGTH-len, msg, ap ); #else vsprintf( &buf[len], msg, ap ); #endif